Project

General

Profile

Actions

Feature #19543

closed

Integrate EXT: ingmar_admpanelwrap

Added by Ingo Renner about 16 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2008-10-30
Due date:
% Done:

0%

Estimated time:
PHP Version:
4.3
Tags:
Complexity:
Sprint Focus:

Description

Problem:
the admin panel currently is tied to a fixed position and con not be moved.

Solution:
Integrate EXT: ingmar_admpanelwrap to enable draging of the admin panel

(issue imported from #M9703)


Files

9703.diff (3.82 KB) 9703.diff Administrator Admin, 2008-10-30 23:41
9703v2.diff (5.91 KB) 9703v2.diff Administrator Admin, 2008-10-31 00:02
9703v2-with-cursor-move.diff.txt (11.8 KB) 9703v2-with-cursor-move.diff.txt Administrator Admin, 2008-10-31 16:48
9703v2-cursor-move-correct.diff (5.92 KB) 9703v2-cursor-move-correct.diff Administrator Admin, 2008-10-31 17:03
9703v3.diff (6.62 KB) 9703v3.diff Administrator Admin, 2008-10-31 18:51
T3X_ingmar_admpanelwrap-modded-by-ricc.t3x (15.2 KB) T3X_ingmar_admpanelwrap-modded-by-ricc.t3x Administrator Admin, 2008-10-31 18:54
9703v4.diff (4.92 KB) 9703v4.diff Administrator Admin, 2009-03-27 02:11
0009703_v5.diff (5.27 KB) 0009703_v5.diff Administrator Admin, 2009-03-30 10:51
Actions #1

Updated by Ingo Renner about 16 years ago

sorry, here's a fixed version. With v1 dragging only worked when the admin panel was open.

Additionally this version switches the order of text and checkboxes in the TypoScript section. Before it could happen that the admin panel beomes very wide because of the content in this section. In this case it was hard to figure which checbox belongs to whcih option as the label might have been outside of the viewport due to scrolling.
This can't happen anymore as the checkboxes are now right in front of the labels.

Actions #2

Updated by Clemens Riccabona about 16 years ago

maybe it should be tested if the xmenu_layers are working properly with this version before integrating into core.
Explanation: With the Ext:ingmar_admpanelwrap the xmenu_layers are not disappearing onmouseover/oncklick if adminpanel is present.

Actions #3

Updated by Clemens Riccabona about 16 years ago

ok, just integrated and uploaded cursor move, and found out what the problem is with the xmenu_layers incompat. The 'document.onmousemove and the document.onmouseup events are the bad boys.

Actions #4

Updated by Clemens Riccabona about 16 years ago

sorry, not really exact.
window.event can make problems as well.

Actions #5

Updated by Ingo Renner about 16 years ago

new version with some cleaned up code and the move cursor on the header of the admin panel

Actions #6

Updated by Clemens Riccabona about 16 years ago

Related to the core-list discussion:
I just added my version of ingmar_admpanelwrap here, as a 'proof of concept' with a working and compatible javascript.
I can't make a patch/diff today (probably on sunday). but if you are hot, just copy and paste my code, it isn't that difficult I think.

I used wz_dragdrop for the dragging operations which is licensed under LGPL, which should be compatible to our GPL (but i'm not a lawyer!).
For storing and restoring positions i used the original 'ingmar' code.

You should test it on several browsers and projects, before integrating to the core, i think.

fun & greetz clemens

Actions #7

Updated by Clemens Riccabona about 16 years ago

a small lack of beauty is, that (on my firefox) the cursor doesn't change anymore, also with the 'cursor:move;' style. i'll have a look at it on sunday.

EDIT: Solved, just have small modifications within wrapBefore:
Change: SET_DHTML("admPanel");
To: SET_DHTML("admPanel"+CURSOR_MOVE);

Actions #8

Updated by Ingo Renner over 15 years ago

committed trunk (4.3)

Actions

Also available in: Atom PDF