Bug #19980

Clean up frontend editing actions

Added by Jeff Segars almost 11 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2009-02-06
Due date:
% Done:

0%

TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The frontend editing actions in t3lib_frontendedit have some small inconsistencies and duplicated code that can be cleaned up.

Calling editing actions based directly on the frontend editing cmd (ie. edit -> $this->edit()) can cause problems with reserved keywords. While this isn't a problem in the current code, the frontend editing controller is extensible so an additional controller that needs to handle the 'new' cmd would have problems. This is fixed by prepending the cmd with 'do' instead (ie. edit -> $this->doEdit()).

Additionally, inconsistencies with saving and duplicated code in the various move functions have been addressed.

(issue imported from #M10372)

0010372.diff View (8.4 KB) Administrator Admin, 2009-02-06 21:11

0010372_v2.diff View (8.63 KB) Administrator Admin, 2009-02-25 21:29

History

#1 Updated by Jeff Segars almost 11 years ago

v2 patch committed to trunk in r5105.

Also available in: Atom PDF