Project

General

Profile

Actions

Bug #21124

closed

White space cleanup

Added by Oliver Klee about 15 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2009-09-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Many editors automatically drop trailing whitespace on saving files. When creating patches, this leads to the white-space cleanup being in the same patches as the actual code changes.

So I've decided to do the cleanup now so future core patches will not have the whitespace cleanup in them.

That's the cleanup which I've done:
- drop trailing whitespace
- drop any whitespace after the closing ?>
- drop surplus blank lines above the ?> and above the class-closing } (not in all files, though)
- drop surplus blank lines around the XCLASS stuff at the bottom of classes
- in one case, fix a type: it's > its
in one case, add a missing space after the "if" in the XCLASS stuff

(issue imported from #M12039)


Files

cleanup.diff (158 KB) cleanup.diff Administrator Admin, 2009-09-22 12:46
Actions #1

Updated by Chris topher over 14 years ago

Has not been sent to Core List...

Actions #2

Updated by Oliver Klee over 14 years ago

I'll create automatic cleaning tools for the separate changes and propose them on the core list.

Actions #3

Updated by Susanne Moog over 13 years ago

  • Status changed from Needs Feedback to Closed
  • Target version deleted (0)
  • TYPO3 Version set to 4.5

If I understand the last comment correctly, this bug can be closed.

Actions

Also available in: Atom PDF