Project

General

Profile

Actions

Bug #21629

closed

MM relations: rollback not working / sys_history wrong

Added by Ralf Hettinger about 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Must have
Category:
-
Target version:
-
Start date:
2009-11-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If changing fields which reference MM relations, sys_history will log these changes by storing a different relation count instead of the differences of referenced records. A rollback will therefore restore the wrong relations (relation to a record with uid=old relation count wil be restored) and the record's history shows wrong information.

Attached patch corrects the referenced uids in sys_history and enables restoring the correct relations as well as providing a correct history of MM changes. It of course can't restore information contained within these MM-relations (like sorting), since MM-relations traditionally have no TCA definition (no deleted flag, no logging...).

This is related to #17106, which is incorporated here.

(issue imported from #M12688)


Files

0012688-4.3-RC1.patch (6.91 KB) 0012688-4.3-RC1.patch Administrator Admin, 2009-11-20 21:40
0012688-4.4-trunk-rev6683.patch (7.09 KB) 0012688-4.4-trunk-rev6683.patch Administrator Admin, 2009-12-19 12:59

Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #17106: Changes of MM relations wont reliably clear the relevant cacheClosedChris topher2007-03-10

Actions
Actions #1

Updated by Chris topher about 15 years ago

Hi Ralf,

thanks for your patch!
To get this finally included (more then two years after you initially wrote it), please post it to the Core List!

Actions #2

Updated by Ralf Hettinger about 15 years ago

Sure thing, it's posted :)

Actions #3

Updated by Ralf Hettinger almost 15 years ago

Been a bug in there which broke sys_history in some cases :(
Is fixed in attached patch.

Actions #4

Updated by Steffen Kamper almost 15 years ago

committed to svn, trunk only (rev 6816)

Actions #5

Updated by Steffen Kamper almost 15 years ago

committed to 4_3 rev 6820

Actions

Also available in: Atom PDF