Bug #22570

Loading scriptaculous with all modules fails with t3lib_compressor

Added by Steffen Gebert over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-05-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you include scriptaculous.js without an addional ?load=mod1,mod2 it loads all its modules:

includes = s.src.match(/\?.*load=([a-z,]*)/);
  includes ? includes[1] : 'builder,effects,dragdrop,controls,slider,sound').split(',').each(
  function(include) { Scriptaculous.require(path+include+'.js') });
});

This doesn't work, when the compressor moved scriptaculous.js into typo3temp/, but not the module scripts.

We have to treat PageRenderer::loadProtaculous() as loadProtaculous('all'), as this is the behavior, which protaculous always did, but now it's not able to do so itself.
So by taking 'all', when no parameter given, we add all modules.

This problem can be observed using IRRE. Sortable is undefined there.
(issue imported from #M14283)


Files

14283.diff (591 Bytes) 14283.diff Administrator Admin, 2010-05-03 09:44

Related issues

Related to TYPO3 Core - Bug #22565: Improve t3lib_compressorClosedSteffen Kamper2010-05-02

Actions
#1

Updated by Steffen Kamper over 10 years ago

Committed to trunk rev 7525

Also available in: Atom PDF