Bug #23509
closedDisabling comment in generated CSS
0%
Description
Can we add a condition in inline style generation to remove comments like:
/* default styles for extension '' */
In this correction I use the disablePrefixComment.
Thanks guy (maybe we can use a new var)
in typo3/sysext/cms/tslib/class.tslib_pagegen.php
Line 502 :
the old one :
$temp_styleLines[] = '/* default styles for extension "' . substr($key, 0, - 1) . '" /' . LF . $iCSScode['_CSS_DEFAULT_STYLE'];
and the new :
$temp_styleLines[] = (!$GLOBALS['TSFE']->config['config']['disablePrefixComment']?'/ default styles for extension "' . substr($key, 0, - 1) . '" */' . LF:'') . $iCSScode['_CSS_DEFAULT_STYLE'];
(issue imported from #M15650)
Updated by Clemens Riccabona about 14 years ago
i can't see a really problem?
if i externalize the css via config, and set config.minifyCSS the whole commenting stuff is gone in the generated css file.
Updated by Christophe Monard about 14 years ago
Like I say in "severity" it's not a problem, it's only cosmetic
Updated by Christophe Monard about 14 years ago
Sure you can add that fact : http://forge.typo3.org/issues/9230
And leaning the code you can the in doCompress function of pagerender :
if ($this->compressCss) {
// own method, nothing implemented atm
}
Updated by Alexander Opitz about 11 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0) - TYPO3 Version set to 4.3
- Is Regression set to No
Hi,
as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?
Updated by Alexander Opitz over 10 years ago
- Status changed from Needs Feedback to Closed
No feedback within the last 90 days => closing this ticket.
If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.