Project

General

Profile

Actions
Copy link

Bug #25020

closed

Red question marks in QuickEdit instead of icons.

Added by comtelsoft about 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Steffen Gebert
Category:
-
Target version:
4.5.1
Start date:
2011-02-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

TCEForms->getIconHTML() is_file fails (line 4159), when checking for a static image file from db_layout.php (Quickview).

PATH_typo3 . $iconArray0 is somthing like that:

/some/path/to/typo3/../../../sysext/t3skin/icons/gfx/i/tt_content_uploads.gif

Now t3lib_div::resolveBackPath clears it to /some/sysext/t3skin/icons/gfx/i/tt_content_uploads.gif but this path doesn't exist.

A solution for me now could be the following, but I am not sure if it has no sideeffects.

- if (is_file(t3lib_div::resolveBackPath(PATH_typo3 . $iconArray0))) {
+ if (is_file(t3lib_div::resolveBackPath(PATH_typo3 .$GLOBALS['temp_modPath']. $iconArray0))) {
(issue imported from #M17564)

Files

17564.diff (735 Bytes) 17564.diff Administrator Admin, 2011-02-13 14:33
Actions
Copy link
 #1

Updated by Steffen Gebert about 13 years ago

Hi comtelsoft,

could you explain, how to reproduce this bug? Are you talking of "QuickEdit" in Page Module?

Steffen

Actions
Copy link
 #2

Updated by comtelsoft about 13 years ago

Hi Steffen,

right, it is the QuickEdit (in German Schnelleingabe).

Fresh TYPO3 4.5 installation, if I go to the quickeditform, it generates following Warning:

PHP Warning: is_file() [function.is-file]: open_basedir restriction in effect. File(/var/www/sysext/t3skin/icons/gfx/wizard_rte2.gif) is not within the allowed path(s): (/var/www/xxxxxxxxxx:/usr/share/php) in /usr/share/php/typo3_src-4.5.0/t3lib/class.t3lib_tceforms.php line 4159.

Consequently, no icons are created (only red question mark)

Actions
Copy link
 #3

Updated by Steffen Gebert about 13 years ago

Okay, that's what I noticed, too. I just wasn't sure, if you're talking of that problem.

Actions
Copy link
 #4

Updated by Steffen Gebert about 13 years ago

Looks good, sounds reasonable!

To get this integrated, could you please send an RFC with the attached patch to the typo3-teams-core mailinglist?
See http://typo3.org/teams/core/core-mailinglist-rules/ or typo3blogger.de/ab-in-den-core/ (german).
Please describe short, what the effect of this bug is (red question marks) and its solution.

Thanks for your contribution!

Actions
Copy link
 #5

Updated by Steffen Gebert about 13 years ago

- trunk rev. 10463
- 4-5 rev. 10464

Thanks for your first contribution, Jürgen! Go on! ;-)

Actions
Copy link

Also available in: Atom PDF