TYPO3 Core

Caroli wrote:

If you use with Typo3 4.5.2 the option "Click to enlarge" there is created a link with the attribute <a target="" etc.>, although the template is configured for xhtml_trans and xhtml_cleaning.
Another description of the problem is found at http://www.typo3forum.net/forum/typo3-4-x-fragen-probleme/50191-xhtml-there-no-attribute-target.html#post166212 (German).

Hello guys,

I think the bug is at sysext/cms/tslib/class.tslib_content.php @ LINE: 1459 to 1471 (TYPO3 4.5.2)
Orginal lines:
// Create TARGET-attribute only if the right doctype is used
if (t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2', $GLOBALS['TSFE']->xhtmlDoctype)) {
$target = isset($conf['target.'])
? $this-stdWrap($conf['target'], $conf['target.'])
: $conf['target'];
if(!$target) {
$target = sprintf(' target="%s"', $target);
} else {
$target = ' target="thePicture"';
}
} else {
$target = '';
}
Solution:
- I think the "if(!$target) {" is wrong. There have to be something like "if ($target) {".

Another BUG in these lines:
$target = isset($conf['target.'])
? $this-stdWrap($conf['target'], $conf['target.'])
: $conf['target'];

Solution:
- this is not correct "? $this-stdWrap". That have to be "? $this->stdWrap".

BR
Yves Poersch

Yves Poersch wrote:

Another BUG in these lines:
$target = isset($conf['target.'])
? $this-stdWrap($conf['target'], $conf['target.'])
: $conf['target'];

Solution:
- this is not correct "? $this-stdWrap". That have to be "? $this->stdWrap".

Absolutely! Please open another issue for that one - as it is obvious this can be fixed right away then.

Christopher wrote:

Yves Poersch wrote:

Another BUG in these lines:
$target = isset($conf['target.'])
? $this-stdWrap($conf['target'], $conf['target.'])
: $conf['target'];

Solution:
- this is not correct "? $this-stdWrap". That have to be "? $this->stdWrap".

Absolutely! Please open another issue for that one - as it is obvious this can be fixed right away then.

I create a new issue for that:
http://forge.typo3.org/issues/26757