Bug #29262: XLIFF: Approved attribute is on wrong element - TYPO3 Core - TYPO3 Forge

Actions

Bug #29262

closed

XLIFF: Approved attribute is on wrong element

Added by Xavier Perseguers about 13 years ago. Updated over 12 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Xavier Perseguers

Category:

-

Target version:

Start date:

2011-08-26

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.6

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Currently attribute approved="yes" is put on target element:

<trans-unit id="some-key">
    <source>some text</source>
    <target approved="yes">some translation</target>
</trans-unit>

But according to XLIFF specification it should be put on trans-unit instead:

<trans-unit id="some-key" approved="yes">
    <source>some text</source>
    <target>some translation</target>
</trans-unit>

This does not hurt currently but only has a wrong effect when importing an XLIFF file into Pootle or Virtaal: all translations are marked as having to be reworked!

Actions

#1

Updated by Xavier Perseguers about 13 years ago

Script to fix XLIFF in Core:

$ cd /path/to/master
$ for f in $(find . -name \*.xlf); do
> sed -i '' 's/<target approved="yes">/<target>/' $f;
> sed -i '' 's/<trans-unit id="\(.*\)">/<trans-unit id="\1" approved="yes">/' $f;
> done

Actions

#2

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change I550eebbdcd549ada4a00c9cba4e45f690262381e has been pushed to the review server.
It is available at http://review.typo3.org/4607

Actions

#3

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change I529dfed1bde3180c53b02136ac5afc5d4a3f6b5a has been pushed to the review server.
It is available at http://review.typo3.org/4608

Actions

#4

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change I1b766376775569888edb025227bcd4cbadccc424 has been pushed to the review server.
It is available at http://review.typo3.org/4609

Actions

#5

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change I4c02a3270af63dca35af782403dd1765afcc7c96 has been pushed to the review server.
It is available at http://review.typo3.org/4610

Actions

#6

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change Id712a3287b38b7fe1687b6c749e263c79df79553 has been pushed to the review server.
It is available at http://review.typo3.org/4611

Actions

#7

Updated by Xavier Perseguers about 13 years ago

Status changed from New to Under Review
% Done changed from 0 to 80

Actions

#8

Updated by Xavier Perseguers about 13 years ago

Status changed from Under Review to Resolved
% Done changed from 80 to 100

Applied in changeset 1633f7618014c7492c1e93c3cb0a8c6203414dfa.

Actions

#9

Updated by Xavier Perseguers over 12 years ago

Status changed from Resolved to Closed

Actions

Also available in: Atom PDF