Project

General

Profile

Actions

Bug #35006

closed

Content Element Media missing slash

Added by Björn Paulsen over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2012-03-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In the file typo3/sysext/cms/tslib/content/class.tslib_content_shockwaveflashobject.php

must be a slash in the line 85:

Wrong:
$conf['flashvars.']['file'] = $prefix . $filename;

Right:
$conf['flashvars.']['file'] = $prefix . '/' .$filename;

because it will be render this and this is wrong:
<object type="application/x-shockwave-flash" data="typo3/contrib/flashmedia/flvplayer.swf" width="600" height="400" id="mmswf4f673801a5076" style="visibility: visible; "><param name="quality" value="high"><param name="menu" value="false"><param name="allowScriptAccess" value="sameDomain"><param name="allowFullScreen" value="true"><param name="flashvars" value="file=http://www.*+domain.defileadmin+*/ContentImages/video.flv"></object>

right will be:
<object type="application/x-shockwave-flash" data="typo3/contrib/flashmedia/flvplayer.swf" width="600" height="400" id="mmswf4f673801a5076" style="visibility: visible; "><param name="quality" value="high"><param name="menu" value="false"><param name="allowScriptAccess" value="sameDomain"><param name="allowFullScreen" value="true"><param name="flashvars" value="file=http://www.*+domain.de/fileadmin+*/ContentImages/video.flv"></object>

Actions #1

Updated by Georg Ringer over 12 years ago

  • Status changed from New to Needs Feedback

line in master is 294

i am not really sure if your report is valid as the $prefix comes from

if ($GLOBALS['TSFE']->baseUrl) {
    $prefix = $GLOBALS['TSFE']->baseUrl;
}
if ($GLOBALS['TSFE']->absRefPrefix) {
    $prefix = $GLOBALS['TSFE']->absRefPrefix;
}

and this means that you are missing the / at the end of your baseUrl or absRefPrefix configuration.

can you please check that and see if this fixes it for you?

Actions #2

Updated by Björn Paulsen over 12 years ago

I inserting a Slash at the end of BaseUrl, and now it rendering correct!

Why there is no function to check and correct that? I had never inserting there a slash, my opinion Base Url is http://wwww.domain.de not http://wwww.domain.de/

Look at Browsers you will also not see the last Slash!

Actions #3

Updated by Georg Ringer over 12 years ago

  • Status changed from Needs Feedback to Closed
  • % Done changed from 0 to 100

absprefprefix is preferred anyways and this is added to all links before the final link, therefore of course the / is needed at the end. same with baseUrl. if no / is defined this can lead to the problem that a browser could try to get http://www.domain.deindex.php?...

however, the problem of this issue is solved, therefore I am closing this issue.

Actions

Also available in: Atom PDF