Actions
Task #38332
closedCleanup: Useless method overriding in t3lib_file_Repository_FileCollectionRepository
Start date:
2012-06-23
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:
Description
In t3lib_file_Repository_FileCollectionRepository the method findByType just calls his parent
/** * Finds record collection by type. * * @param string $type The type to be looked up * @return NULL|t3lib_file_Collection_AbstractFileCollection[] */ public function findByType($type) { return parent::findByType($type); }
This is quite useless, because due OOP, the parent method (t3lib_collection_RecordCollectionRepository::findByType) is called, if t3lib_file_Repository_FileCollectionRepository does not provide a local / override method.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12311
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12311
Updated by Gerrit Code Review over 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12311
Updated by Andy Grunwald over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7c8608dbc3f978e13cb5c2b80774bd8243076523.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed
Actions