Project

General

Profile

Actions

Task #38333

closed

Cleanup: Useless method overriding in t3lib_spritemanager_SimpleHandler

Added by Andy Grunwald over 12 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2012-06-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

In t3lib_spritemanager_SimpleHandler the method __construct just calls his parent

/**
 * constructor just init's the temp-file-name
 * @return void
 */
public function __construct() {
    parent::__construct();
}

This is quite useless, because due OOP, the parent method (t3lib_spritemanager_AbstractHandler::__construct) is called, if t3lib_spritemanager_SimpleHandler does not provide a local / override method.

Actions #1

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12312

Actions #2

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12312

Actions #3

Updated by Andy Grunwald over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF