Actions
Task #38335
closedUseless method overriding in EXT:form
Start date:
2012-06-23
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:
Description
In sysext "form" many methods are implemented twice.
Many methods just call his parents without any modification.
One example is tx_form_System_Validate_Digit::__construct():
/** * Constructor * * @param array $arguments Typoscript configuration * @return void */ public function __construct($arguments) { parent::__construct($arguments); }
This is quite useless, because due OOP, the parent method is called, if the local class does not provide a local / override method.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12314
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12314
Updated by Andy Grunwald over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2f2c906c96f80b57ea5c5dac6a3cd0801cc3de72.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed
Actions