Project

General

Profile

Actions

Task #38532

closed

Fix CGL violations against Squiz.PHP.NonExecutableCode

Added by Andy Grunwald over 12 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2012-07-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description


FILE: /var/www/websites/master/htdocs/t3lib/file/FileReference.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 353 | WARNING | Code after THROW statement cannot be executed
 366 | WARNING | Code after THROW statement cannot be executed
--------------------------------------------------------------------------------

FILE: /var/www/websites/master/htdocs/t3lib/mail/class.t3lib_mail_mailer.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 161 | WARNING | Empty return statement not required here
--------------------------------------------------------------------------------

Time: 11:14, Memory: 138.25Mb

Time: 01:01, Memory: 50.00Mb

FILE: ...ar/www/websites/master/htdocs/typo3/sysext/cms/tslib/class.tslib_fe.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 7 WARNING(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
 4232 | WARNING | Code after RETURN statement cannot be executed
 4233 | WARNING | Code after RETURN statement cannot be executed
 4234 | WARNING | Code after RETURN statement cannot be executed
 4235 | WARNING | Code after RETURN statement cannot be executed
 4236 | WARNING | Code after RETURN statement cannot be executed
 4239 | WARNING | Code after RETURN statement cannot be executed
 4240 | WARNING | Code after RETURN statement cannot be executed
--------------------------------------------------------------------------------

FILE: ...master/htdocs/typo3/sysext/em/classes/tools/class.tx_em_tools_unzip.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 134 | WARNING | Empty return statement not required here
--------------------------------------------------------------------------------

FILE: /var/www/websites/master/htdocs/typo3/sysext/impexp/class.tx_impexp.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 4 WARNING(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
 1816 | WARNING | Code after BREAK statement cannot be executed
 1817 | WARNING | Code after BREAK statement cannot be executed
 1819 | WARNING | Code after BREAK statement cannot be executed
 1820 | WARNING | Code after BREAK statement cannot be executed
--------------------------------------------------------------------------------

FILE: ...ww/websites/master/htdocs/typo3/sysext/install/mod/class.tx_install.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 19 WARNING(S) AFFECTING 19 LINE(S)
--------------------------------------------------------------------------------
 3031 | WARNING | Code after EXIT statement cannot be executed
 3032 | WARNING | Code after EXIT statement cannot be executed
 3033 | WARNING | Code after EXIT statement cannot be executed
 3034 | WARNING | Code after EXIT statement cannot be executed
 3035 | WARNING | Code after EXIT statement cannot be executed
 3036 | WARNING | Code after EXIT statement cannot be executed
 3037 | WARNING | Code after EXIT statement cannot be executed
 3038 | WARNING | Code after EXIT statement cannot be executed
 3040 | WARNING | Code after EXIT statement cannot be executed
 3041 | WARNING | Code after EXIT statement cannot be executed
 3042 | WARNING | Code after EXIT statement cannot be executed
 3044 | WARNING | Code after EXIT statement cannot be executed
 3045 | WARNING | Code after EXIT statement cannot be executed
 3047 | WARNING | Code after EXIT statement cannot be executed
 3048 | WARNING | Code after EXIT statement cannot be executed
 3049 | WARNING | Code after EXIT statement cannot be executed
 3050 | WARNING | Code after EXIT statement cannot be executed
 3053 | WARNING | Code after EXIT statement cannot be executed
 3055 | WARNING | Code after EXIT statement cannot be executed
--------------------------------------------------------------------------------

FILE: ...ar/www/websites/master/htdocs/typo3/sysext/rtehtmlarea/ext_autoload.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 19 | WARNING | Code after RETURN statement cannot be executed
--------------------------------------------------------------------------------

FILE: ...master/htdocs/typo3/sysext/rtehtmlarea/pi1/class.tx_rtehtmlarea_pi1.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 4 WARNING(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
 305 | WARNING | Empty return statement not required here
 332 | WARNING | Empty return statement not required here
 406 | WARNING | Empty return statement not required here
 415 | WARNING | Empty return statement not required here
--------------------------------------------------------------------------------

Time: 20:56, Memory: 148.50Mb
Actions #1

Updated by Mathias Schreiber almost 10 years ago

  • Status changed from New to Closed

I'm closing these down.
We will need to come up with a reliable way of including codesniffs into the development process

Actions

Also available in: Atom PDF