Project

General

Profile

Actions

Task #38753

closed

Split up classes into single files

Added by Andy Grunwald over 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2012-07-08
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

In the TYPO3 core, some files contain more than one class.
This is a) against the CGL and b) not very useful if someone wants to use only only class.

Due to the autoloader, we can move / split up this mess into separate files.

FILE: ...rs/andygrunwald/Development/TYPO3/typo3_src-git/typo3/alt_clickmenu.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1578 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...dygrunwald/Development/TYPO3/typo3_src-git/typo3/class.browse_links.php
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
 210 | ERROR | Only one class is allowed in a file.
 352 | ERROR | Only one class is allowed in a file.
 362 | ERROR | Only one class is allowed in a file.
 403 | ERROR | Only one class is allowed in a file.
 470 | ERROR | Only one class is allowed in a file.
 480 | ERROR | Only one class is allowed in a file.
 522 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: /Users/andygrunwald/Development/TYPO3/typo3_src-git/typo3/db_new.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 83 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: /Users/andygrunwald/Development/TYPO3/typo3_src-git/typo3/move_el.php
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
  72 | ERROR | Only one class is allowed in a file.
 122 | ERROR | Only one class is allowed in a file.
 159 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: /Users/andygrunwald/Development/TYPO3/typo3_src-git/typo3/show_item.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 95 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...nwald/Development/TYPO3/typo3_src-git/typo3/sysext/beuser/mod/index.php
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
 135 | ERROR | Only one class is allowed in a file.
 183 | ERROR | Only one class is allowed in a file.
 272 | ERROR | Only one class is allowed in a file.
 353 | ERROR | Only one class is allowed in a file.
 377 | ERROR | Only one class is allowed in a file.
 960 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...d/Development/TYPO3/typo3_src-git/typo3/sysext/cms/layout/db_layout.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 130 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...pment/TYPO3/typo3_src-git/typo3/sysext/cms/layout/db_new_content_el.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 102 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...lopment/TYPO3/typo3_src-git/typo3/sysext/cms/tslib/class.tslib_menu.php
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
 1837 | ERROR | Only one class is allowed in a file.
 2193 | ERROR | Only one class is allowed in a file.
 2771 | ERROR | Only one class is allowed in a file.
 3017 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...ment/TYPO3/typo3_src-git/typo3/sysext/cms/tslib/class.tslib_pagegen.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1174 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: .../TYPO3/typo3_src-git/typo3/sysext/cms/web_info/class.tx_cms_webinfo.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 181 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...ld/Development/TYPO3/typo3_src-git/typo3/sysext/cshmanual/mod/index.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 60 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...nwald/Development/TYPO3/typo3_src-git/typo3/sysext/impexp/app/index.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 210 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...pment/TYPO3/typo3_src-git/typo3/sysext/indexed_search/class.crawler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 916 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...YPO3/typo3_src-git/typo3/sysext/rtehtmlarea/class.tx_rtehtmlareaapi.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 233 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...git/typo3/sysext/rtehtmlarea/mod3/class.tx_rtehtmlarea_browse_links.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 107 | ERROR | Only one class is allowed in a file.
 156 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: ...git/typo3/sysext/rtehtmlarea/mod4/class.tx_rtehtmlarea_select_image.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 101 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: /Users/andygrunwald/Development/TYPO3/typo3_src-git/typo3/template.php
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
 2070 | ERROR | Only one class is allowed in a file.
 2079 | ERROR | Only one class is allowed in a file.
 2088 | ERROR | Only one class is allowed in a file.
 2097 | ERROR | Only one class is allowed in a file.
 2104 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

FILE: .../andygrunwald/Development/TYPO3/typo3_src-git/typo3/wizard_tsconfig.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 68 | ERROR | Only one class is allowed in a file.
--------------------------------------------------------------------------------

Time: 07:16, Memory: 106.25Mb
Actions #1

Updated by Andy Grunwald over 12 years ago

I`m currently working on it.

Actions #2

Updated by Andy Grunwald over 12 years ago

I stop working on it, because of #38754

Actions #3

Updated by Helmut Hummel almost 12 years ago

  • Status changed from New to Closed

Resolved with #40095 \o/

Actions

Also available in: Atom PDF