Bug #39019: t3lib_formmail: generates incorrect file upload error - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #39019

closed

t3lib_formmail: generates incorrect file upload error

Added by Ronald Eijkman about 12 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Ernesto Baschny

Category:

Target version:

Start date:

2012-07-17

Due date:

% Done:

100%

Estimated time:

0.01 h

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

In t3lib/class.t3lib_formmail.php of TYPO3 4.5 and higher, file upload errors are checked with:

if ($_FILES[$variableName]['tmp_name']['error'] !== UPLOAD_ERR_OK)

This always generates a syslog entry. This should be:

if ($_FILES[$variableName]['error'] !== UPLOAD_ERR_OK)

Actions

Copy link

Updated by Ernesto Baschny about 12 years ago

Status changed from New to Accepted
Assignee set to Ernesto Baschny

Good catch, the sysLoging is indeed incorrect. Also the order of logging is not right, because it will always incorrectly also report "Possible abuse of t3lib_formmail" in case there was an error uploading.

Will fix it ASAP, please wait to review it. Thanks!

Actions

Copy link

Updated by Gerrit Code Review about 12 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12846

Actions

Copy link

Updated by Ernesto Baschny about 12 years ago

% Done changed from 0 to 50

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12846

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12846

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12846

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12846

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36256

Actions

Copy link