Project

General

Profile

Actions
Copy link

Bug #39173

closed

Cleanup ext_emconf booleans

Added by Felix Kopp over 12 years ago. Updated over 11 years ago.

Status:
Rejected
Priority:
Could have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-07-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Make booleans real booleans, and not integers

Actions
Copy link
 #1

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12988

Actions
Copy link
 #2

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12988

Actions
Copy link
 #3

Updated by Ernesto Baschny over 12 years ago

  • Status changed from Under Review to Needs Feedback

You need to fix the method that re-generates the ext_emconf.php first before we can change it, else we will end up again and again with the integers in these fields.

See function em/classes/tools/class.tx_em_tools.php method arrayToCode() and em/classes/extensions/class.tx_em_extensions_details.php method construct_ext_emconf_file.

I guess we will first have to create a structured documentation of which fields might contain which data type to be able to automatically "convert" buggy integers to booleans etc.

But my 2ct: not worth it?

Actions
Copy link
 #4

Updated by Christian Kuhn over 11 years ago

  • Status changed from Needs Feedback to Rejected
Actions
Copy link

Also available in: Atom PDF