Bug #39176
closed
tslib_cObj::filelist() implodes filenames by , without caring about commas in filenames
0%
Description
For example the component tt_content.uploads.20, which gets it's funtionality from
typo3/sysext/css_styled_content/pi1/class.tx_cssstyledcontent_pi1.php in render_uploads()
uses tslib_cObj::filelist().
That function however implodes all filenames it finds with commas. When the filenames themselves include commas that results into problems.
(This problem exists since as long I can remember in TYPO3.)
Updated by Stefan Neufeind over 12 years ago
Could we make filelist() return an array instead of a comma-separated list maybe? By turning it into filelistArray() and making filelist() just a compat-function which implodes what comes from filelistArray()?
Then other functions could fetch a filelist without having to explode it again, for example by updating cssstyledcontent as well.
Starting with 6.0 maybe filelist() could be deprecated then with a @see filelistArray().
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12991
Updated by Ingo Renner over 12 years ago
good find, but I wouldn't deprecate filelist() since usually in TS you handle strings, not arrays...
Updated by Gerrit Code Review almost 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review almost 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review over 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review over 11 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review over 11 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review over 11 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review over 11 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review over 11 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review about 11 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review about 11 years ago
Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Gerrit Code Review almost 11 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/12991
Updated by Stefan Neufeind almost 10 years ago
- Status changed from Under Review to Rejected
- Is Regression set to No
Not for 4.5 anymore. And for 6.x filelists are deprecated in favor of FILES cObject.