Bug #50843
closedFix TYPO3\CMS\Core\Tests\Unit\Resource\FactoryTest on Windows systems
100%
Description
The test retrieveFileOrFolderObjectReturnsFolderIfPathIsGiven in class TYPO3\CMS\Core\Tests\Unit\Resource\FactoryTest fails with warnings
Retrieve file or folder object returns folder if path is given with data set "relative path"
Failure in test case retrieveFileOrFolderObjectReturnsFolderIfPathIsGiven with data set "relative path"
File: D:\TYPO3\TYPO3 extensions\phpunit\Composer\vendor\phpunit\phpunit-mock-objects\PHPUnit\Framework\MockObject\InvocationMocker.php
Line: 198
Expectation failed for method name is equal to <string:getFolder> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
retrieveFileOrFolderObjectReturnsFolderIfPathIsGiven with data set "path with PATH site"
Failure in test case retrieveFileOrFolderObjectReturnsFolderIfPathIsGiven with data set "path with PATH_site"
File: D:\TYPO3\TYPO3 extensions\phpunit\Composer\vendor\phpunit\phpunit-mock-objects\PHPUnit\Framework\MockObject\InvocationMocker.php
Line: 198
Expectation failed for method name is equal to <string:getFolder> when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.
This is because of two single issues. First of all a folder is tested which (might) belong to an own storage other than storage 0. On the other hand on Windows system a full path contains always an colon which breaks any storage check. We have to fix any absolute path beforehand as it is done in the sub functions as well.
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22894
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22894
Updated by Nicole Cordes over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset cc31a4d17b0247e9e5e2d22f43c4f16814fd34e7.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22912
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22914
Updated by Nicole Cordes over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset f3f221d24eebb7f61e8998330a9a49a5a0542bf1.