Project

General

Profile

Actions

Feature #51782

closed

allWrap property for CSS and JavaScript files replaces all pipes ("|")

Added by Christoph Dörfel over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2013-09-05
Due date:
% Done:

100%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
easy
Sprint Focus:

Description

When CSS or JavaScript files are wrapped through the ".allWrap" property (@see TSref->Page->includeCSS), all pipe symbols ("|") are replaced with the generated tag.

file1 = fileadmin/templates/style.css
file1.allWrap = X | Y | Z

results in

X <link rel="stylesheet" type="text/css" [..] /> Y <link rel="stylesheet" type="text/css" [..] /> Z

This behaviour differs from what we are used to with wraps in TYPO3.
".allWrap" should behave like "stdWrap.wrap", with the addition of a splitChar, e.g: "allWrap /+.splitChar"

Code in
\TYPO3\CMS\Core\Page\PageRenderer->renderCssFiles()
and
\TYPO3\CMS\Core\Page\PageRenderer->renderJavaScriptFiles()

Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23669

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23669

Actions #3

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23669

Actions #4

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23669

Actions #5

Updated by Christoph Dörfel over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF