Feature #51865
closed
sizes in viewpage preview frame selector should be configurable
100%
Description
Since #51148 the viewpage module shows a selector for frame sizes "based on most common sizes".
This is different in most projects (target group) so both, sizes and labels should be extendable and configurable with TSConfig.
Updated by Ernesto Baschny over 10 years ago
- Category set to Backend User Interface
- Status changed from New to Accepted
- Priority changed from Should have to Must have
There was a "lengthy" discussion after this feature was merged on Twitter, and this is indeed an important missing option of this new feature that I would like to see finished.
The choices of "Preview" are very project dependent and each implementation has it's own requirements and "sizes" it has to support. We need this configurable and the core only providing a very generic default set that is not so controversial as the current set.
Thanks for bringing that topic up here, Joh!
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720
Updated by Joh. Feustel over 10 years ago
- There must be a default option with width: auto
- Selection must be saved in session
- Frame should be resizeable and this manual value should also be stored in the session (as a new option)
- Frame margin must be visually separated from iframe
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720
Updated by Gerrit Code Review over 10 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720
Updated by Gerrit Code Review over 10 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720
Updated by Gerrit Code Review over 10 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720
Updated by Joh. Feustel over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b546e865d1f1346070aff59454cceb2c1c4a9d8f.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed