Feature #51865

sizes in viewpage preview frame selector should be configurable

Added by Joh. Feustel over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2013-09-09
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Since #51148 the viewpage module shows a selector for frame sizes "based on most common sizes".
This is different in most projects (target group) so both, sizes and labels should be extendable and configurable with TSConfig.


Related issues

Related to TYPO3 Core - Feature #51148: Responsive preview adaption Closed 2013-08-18
Related to TYPO3 Core - Feature #51933: viewpage usablity optimization Closed 2013-09-12

Associated revisions

Revision b546e865 (diff)
Added by Joh. Feustel over 6 years ago

[FEATURE] Make frame sizes in viewpage module configurable

Available sizes in viewpage module can be configured with Page
TSConfig mod.web_view.previewFrameWidths. Defining a height
property is optional.

Change-Id: I7900959bc76fc2c586307c0fd4200f9665876dd3
Resolves: #51865
Documentation: #52783
Releases: 6.2
Reviewed-on: https://review.typo3.org/23720
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Ernesto Baschny over 6 years ago

  • Category set to Backend User Interface
  • Status changed from New to Accepted
  • Priority changed from Should have to Must have

There was a "lengthy" discussion after this feature was merged on Twitter, and this is indeed an important missing option of this new feature that I would like to see finished.

The choices of "Preview" are very project dependent and each implementation has it's own requirements and "sizes" it has to support. We need this configurable and the core only providing a very generic default set that is not so controversial as the current set.

Thanks for bringing that topic up here, Joh!

#2 Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720

#3 Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720

#4 Updated by Joh. Feustel over 6 years ago

Other glitches of these feature probably to be fixed another issue are
  • There must be a default option with width: auto
  • Selection must be saved in session
  • Frame should be resizeable and this manual value should also be stored in the session (as a new option)
  • Frame margin must be visually separated from iframe

#5 Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720

#6 Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720

#7 Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720

#8 Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720

#9 Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23720

#10 Updated by Joh. Feustel over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF