Bug #54018: Extra compare in InlineElement::renderForeignRecord() - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #54018

closed

Extra compare in InlineElement::renderForeignRecord()

Added by Michiel Roos about 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Performance

Target version:

next-patchlevel

Start date:

2013-11-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

The line:

$isNewRecord = MathUtility::canBeInterpretedAsInteger($rec['uid']) ? FALSE : TRUE;

Can be replaced with:

$isNewRecord = MathUtility::canBeInterpretedAsInteger($rec['uid']);

Since MathUtility::canBeInterpretedAsInteger() returns a boolean.

Actions

Copy link

Updated by Michiel Roos about 11 years ago

That should be:
$isNewRecord = !MathUtility::canBeInterpretedAsInteger($rec['uid']);

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25714

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25714

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25714

Actions

Copy link