Project

General

Profile

Actions

Bug #54021

closed

Cleanup convertParameterReflectionToArray()

Added by Michiel Roos over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
Start date:
2013-11-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

ReflectionService::convertParameterReflectionToArray() builds an array like so:

$parameterInformation = array(
'position' => $parameterPosition,
'byReference' => $parameter->isPassedByReference() ? TRUE : FALSE,
'array' => $parameter->isArray() ? TRUE : FALSE,
'optional' => $parameter->isOptional() ? TRUE : FALSE,
'allowsNull' => $parameter->allowsNull() ? TRUE : FALSE
);

The functions all return Boolean values and do not need to be tested for boaleanness again:

$parameterInformation = array(
'position' => $parameterPosition,
'byReference' => $parameter->isPassedByReference(),
'array' => $parameter->isArray(),
'optional' => $parameter->isOptional(),
'allowsNull' => $parameter->allowsNull()
);
Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25717

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25717

Actions #3

Updated by Michiel Roos about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF