Project

General

Profile

Actions
Copy link

Bug #54557

closed

CharsetConverter::crop calls utf8_char2byte_pos when encoding is utf-8

Added by Michiel Roos almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
next-patchlevel
Start date:
2013-12-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

  • Regular PHP substr() works fine on regular UTF-8 strings;
  • TYPO3 backend is fully UTF-8 based by default in 6.1;
  • Database connection is enforced to be UTF-8 during bootstrap;

The call to utf8_char2byte_pos() can be skipped and the substr() result returned immediately when the charSet is utf-8.

Actions
Copy link
 #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26536

Actions
Copy link
 #2

Updated by Michiel Roos almost 11 years ago

Please close. My mbstring was not properly setup in the install tool.

Actions
Copy link
 #3

Updated by Markus Klein almost 11 years ago

  • Status changed from Under Review to Closed
Actions
Copy link

Also available in: Atom PDF