Bug #54807
closed
Indexed Search PageBrowsing ViewHelper defines unused method argument in phpdoc comments
100%
Description
The PHP-Doc comments for the render-method in PageBrowsing Viewhelper on Indexed Search define a $details argument for that method with is then not part of the method arguments itself.
As it seems to be unused the argument definition should simply be removed from doc comments to dont mess up the defintions of the other arguments.
Right now this results in maximumNumberOfResultPages be defined as array and causes a fatal error like:
The argument "maximumNumberOfResultPages" was registered with type "array", but is of type "string" in view helper "TYPO3\CMS\IndexedSearch\ViewHelpers\PageBrowsingViewHelper"
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26676
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26676
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26676
Updated by Gerrit Code Review over 10 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26679
Updated by Benjamin Rau over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 272f80c5a1394c6789b4b4432d212eacc65eab94.
Updated by