Bug #55443: List Module - wrong colspan in table footer - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #55443

closed

List Module - wrong colspan in table footer

Added by Marcin Sągol about 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend User Interface

Target version:

6.2.0

Start date:

2014-01-29

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.5

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If we enter List Module we have tables with various records list available. Each table shows by default 20 records of each type (if we are not in single record list). If there is more records to show than mentioned value, then each table has also footer that contains some linked info - see attached link. This footer is just next row in table that contains one cell with property 'colspan'. The colspan value is wrong though - it doesn't count one column somehow and that leas to viusual issue seen on screen (bottom table border).

Also i'm not sure why there are always some empty columns renderd (see the last 3):

<tr class="db_list_normal"> <td nowrap="nowrap" class="col-icon">icon</td> <td nowrap="nowrap" class="col-title">title</td> <td nowrap="nowrap" class=""></td> <td nowrap="nowrap" class=""> </td> <td nowrap="nowrap" class=""></td> </tr>

Files

db_records_list_footer.jpg (6.27 KB) db_records_list_footer.jpg

Marcin Sągol, 2014-01-29 21:25

Actions

Copy link

Updated by Marcin Sągol about 10 years ago

Just quick search:
Colspan attribute is calculated based on items in array: $this->fieldArray

line 548:
$iOut .= '<tr><td colspan="' . count($this->fieldArray) . '" style="padding:5px;">

in file:
typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php

but in file:

typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php

we have function called addElement() and there before items in $this->fieldArray() are rendered is statement is executed:
if ($this->showIcon) { ... }

and here inside is generated extra table cell:
<td nowrap="nowrap" class="col-icon">..</td>

and probably this cell is missing when calculating value for colspan.

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27448

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27448

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27448

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27448

Actions

Copy link