Project

General

Profile

Actions

Bug #55991

closed

redundant calls to getClassSchema() in DataMapper::thawProperties()

Added by Michiel Roos almost 11 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
Start date:
2014-02-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

getClassSchema() is being called within a foreach loop while the $className never changes for that call.

I know that method chaining is hip and all . . . but for an extension like the Backend Log, moving the call outside of the loop can save 7046 calls of the 7548 calls to getClassSchema().

Actions #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27633

Actions #2

Updated by Michiel Roos almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF