Project

General

Profile

Actions

Bug #56208

closed

Remove redundant method admin_query or sql_query

Added by Stefano Kowalke about 10 years ago. Updated almost 9 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2014-02-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Both method doing exactly the same thing:

    public function sql_query($query) {
        $res = $this->query($query);
        if ($this->debugOutput) {
            $this->debug('sql_query', $query);
        }
        return $res;
    }

    public function admin_query($query) {
        $res = $this->query($query);
        if ($this->debugOutput) {
            $this->debug('admin_query', $query);
        }
        return $res;

Can't see the reason why we need both methods. I would prefer to remove the sql_query().

Actions #1

Updated by Benni Mack about 9 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Benni Mack
  • Target version deleted (6.2.0)
  • PHP Version deleted (5.4)

We need both methods for now, as DBAL is doing some logic for each of the methods, with different use-cases.

As long as we have DBAL we need both :(

Actions #2

Updated by Benni Mack almost 9 years ago

  • Status changed from Needs Feedback to Rejected

sorry, as mentioned we need to keep this until DBAL is gone.

Actions

Also available in: Atom PDF