Bug #56770

Install Tool flash messages in Step Installer

Added by Ernesto Baschny over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Could have
Category:
Install Tool
Target version:
Start date:
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The Step Installer sometimes want to present some "flash messages" which are passed over from one controller to the next through the session. Currently these messages are displayed over Step installer box.

And this looks ugly:

This looks especially ugly in the first step of the Step Installer if the install tool tries to create the directory structure and fails on every single directory due to permission problems.

This is just a tiny adaptation to make it "less ugly", could be turned over again later on if we find an even better solution.

My pragmatic suggestion for now looks like this:

install-tool-message-original.png View (37.1 KB) Ernesto Baschny, 2014-03-11 16:51

install-tool-message-new.png View (34.4 KB) Ernesto Baschny, 2014-03-11 16:51

Associated revisions

Revision d728b85f (diff)
Added by Ernesto Baschny over 4 years ago

[BUGFIX] Install Tool flash messages in Step Installer styling

Releases: master, 6.2
Resolves: #56770
Change-Id: I17683468f82542f627c886e9234ccd443994e84c
Reviewed-on: http://review.typo3.org/28263
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 30775dd9 (diff)
Added by Ernesto Baschny over 4 years ago

[BUGFIX] Install Tool flash messages in Step Installer styling

Releases: master, 6.2
Resolves: #56770
Change-Id: I17683468f82542f627c886e9234ccd443994e84c
Reviewed-on: http://review.typo3.org/35945
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28263

#2 Updated by Felix Kopp over 5 years ago

I am not a fan of the integrated FlashMessages - might be added into the container above the content. But please do not add an extra container "Messages"

#3 Updated by Ernesto Baschny over 5 years ago

Well, you mean keeping them above even the title of the page? Have you had 3 or 4 (or even 20) of these flash messages over the content box? Try fixing permissions in "Step 1" if your root directory is not writeable by the server. Outside the box the Flash messages are totally unstyled. As if someone forgot to do something here. Looks ugly! :)

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/28263

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35945

#6 Updated by Ernesto Baschny over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF