Project

General

Profile

Actions

Bug #57123

closed

FAL - storage inside storage - very big performance downgrade with big data sets (20k) when opening filebrowser

Added by Krystian Szymukowicz over 10 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
Won't have this time
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2014-03-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

I have a TYPO3 project (inherited) where storage is inside storage.

Storage 1 is default:
/fileadmin/

Storage 2 is
/fileadmin/media/

Now when opening a file browser to select a file I must wait like 10 seconds. After debugging it turns out that the performance downgrade is because the "_processed_" folder files of second storage are shown in first storage.

The class responsible for that is here
/typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php
public function getFolderTree(\TYPO3\CMS\Core\Resource\Folder $folderObject, $depth = 999, $type = '') {

If we remove "_processed_" folder from $subFolders then performance is ok.

Actions #1

Updated by Wouter Wolters over 10 years ago

  • Subject changed from FAL - storage inside storage - very big performance downgrade with big data sets (20k) wehn opening filebrowser to FAL - storage inside storage - very big performance downgrade with big data sets (20k) when opening filebrowser
Actions #2

Updated by Krystian Szymukowicz over 10 years ago

BTW: The downgrade is only when there are lot of files inside processed.
When there is lot of sys_files records but not yet processed then everything is OK.

Actions #3

Updated by Krystian Szymukowicz over 10 years ago

I'd like to ask also if its good to show "_processed_" folder for regular user at all.
What if user will start to select files from this folder?

What can be the reason to select file from that folder even for admin user?

I'd opt for removing that folder from file browser.

Actions #4

Updated by Ernesto Baschny over 10 years ago

  • Status changed from New to Needs Feedback

I would recommend getting rid of this structure. Do not nest a storage inside another storage's path. This might lead to all kinds of trouble.

Actions #5

Updated by Krystian Szymukowicz over 10 years ago

Yes - you right.
I just realized that someone on this TYPO3 project I am on now just misused idea of storage with idea of mount points.

Actions #6

Updated by Ernesto Baschny over 10 years ago

  • Status changed from Needs Feedback to Rejected
  • Priority changed from Must have to Won't have this time

Thanks for the quick feedback, so I'll close this issue for now. If you find other kinds of troubles, don't hesitate to report in separate issues.

Actions

Also available in: Atom PDF