Project

General

Profile

Actions

Bug #57273

closed

Wrong SignalSlot dispatch calls in ResourceStorage

Added by Frans Saris over 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
-
Target version:
-
Start date:
2014-03-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

The ->dispatch calls made in the following methods is wrong:

  • ResourceStorage::emitPreFolderCopySignal()
  • ResourceStorage::emitPostFolderCopySignal()
  • ResourceStorage::emitPreFolderMoveSignal()
  • ResourceStorage::emitPostFolderMoveSignal()
  • ResourceStorage::emitPreFolderRenameSignal()
  • ResourceStorage::emitPostFolderRenameSignal()
  • ResourceStorage::emitPreFolderDeleteSignal()
  • ResourceStorage::emitPostFolderDeleteSignal()

The wrong classname is used and for emitPreFolderCopySignal(), emitPostFolderCopySignal(), emitPreFolderMoveSignal() and emitPostFolderMoveSignal() the $newName parameter isn't passed through.

Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28743

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28743

Actions #3

Updated by Frans Saris over 10 years ago

This can be tested with this extension https://github.com/beechit/fal_securedownload/tree/core-57273

1. Set your storage to non public
2. right click on a folder in the filemodule and click 'Folder permissions'
3. add a fe group and save
4. Move and/or rename the folder where you set the permissions

The folder permissions should move with every action you do. Easy visible by the icon overlays.

Actions #4

Updated by Frans Saris over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF