Project

General

Profile

Actions

Bug #59564

closed

display of MD5 errors is false

Added by Johannes Goslar almost 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-06-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If fetchExtension in typo3/sysext/extensionmanager/Classes/Utility/Connection notices that the md5 sums mismatch, it will call

throw new ExtensionManagerException('Error: MD5 hash of downloaded file not as expected:<br />' . $md5 . ' != ' . $expectedMd5, 1334426098);

This is catched in installFromTer as
catch (\TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException $e) {
            $errorMessages = array(
                $extension->getExtensionKey() => array(
                    'code' => $e->getCode(),
                    'message' => $e->getMessage(),
                ),
            );
        }

Which is coming from
    public function installFromTerAction(\TYPO3\CMS\Extensionmanager\Domain\Model\Extension $extension, $downloadPath) {
        list($result, $errorMessages) = $this->installFromTer($extension, $downloadPath);
        $this->view
            ->assign('result', $result)
            ->assign('extension', $extension)
            ->assign('unresolvedDependencies', $errorMessages);
    }

This will result in a typo3/sysext/extbase/Classes/Mvc/View/NotFoundView.php showing the following text:

Sorry, the requested view was not found.

The technical reason is: Array.

but should instead show a view relating to the extension manager.

Actions #1

Updated by Sascha Egerer almost 10 years ago

There is a @TODO in the Code ;-)

@// @TODO: write Template
    $this->view
        ->assign('result', $result)
        ->assign('errorMessage', $errorMessage);

I would suggest to not write a view here but redirect to the distribution list view and add a flash message that something was wrong.

Actions #2

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31241

Actions #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31264

Actions #4

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31241

Actions #5

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31241

Actions #6

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31241

Actions #7

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31268

Actions #8

Updated by Anonymous almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF