Project

General

Profile

Actions

Bug #59991

closed

Extensionmanager Method installFromTer returns error messages in wrong array structure

Added by Sascha Egerer over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extension Manager
Target version:
Start date:
2014-06-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The method TYPO3\CMS\Extensionmanager\Controller\DownloadController\installFromTer catches exceptions of type \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException and stores them in an array that will be used in the return value of the function.
The array with the error messages is passed to a fluid template but it requires a different array structure then the current.

Current structure:

array(
    'extension_name' => array(
        'code' => 123
        'message' => 'test message'
    )
)

Expected structure:

array(
    'extension_name' => array(
        array (
            'code' => 123
            'message' => 'test message'
        )
    )
)


Files

current.png (63.1 KB) current.png Sascha Egerer, 2014-07-01 16:38
expected.png (68.9 KB) expected.png Sascha Egerer, 2014-07-01 16:38
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240

Updated by Sascha Egerer over 9 years ago

Testplan to reproduce this issue:

Go to the Extension manager in the "Get Extension" module.

Edit the file typo3/sysext/extensionmanager/Classes/Utility/Connection/TerUtility.php. Change

        if ($md5 === $expectedMd5) {

to
        if ($md5 !== $expectedMd5) {

to simulate an invalid md5 hash.

Now klick the "Import and install" button for an extension.

Current result:

Expected result (after the patch is applied):

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31267

Actions #7

Updated by Anonymous over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF