Bug #59991
closedExtensionmanager Method installFromTer returns error messages in wrong array structure
100%
Description
The method TYPO3\CMS\Extensionmanager\Controller\DownloadController\installFromTer
catches exceptions of type \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException
and stores them in an array that will be used in the return value of the function.
The array with the error messages is passed to a fluid template but it requires a different array structure then the current.
Current structure:
array( 'extension_name' => array( 'code' => 123 'message' => 'test message' ) )
Expected structure:
array( 'extension_name' => array( array ( 'code' => 123 'message' => 'test message' ) ) )
Files
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240
Updated by Sascha Egerer over 10 years ago
- File current.png current.png added
- File expected.png expected.png added
Testplan to reproduce this issue:
Go to the Extension manager in the "Get Extension" module.
Edit the file typo3/sysext/extensionmanager/Classes/Utility/Connection/TerUtility.php
. Change
if ($md5 === $expectedMd5) {
to
if ($md5 !== $expectedMd5) {
to simulate an invalid md5 hash.
Now klick the "Import and install" button for an extension.
Current result:
Expected result (after the patch is applied):
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31240
Updated by Gerrit Code Review over 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31267
Updated by Anonymous over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f3883006f086ec3fd0b8ddfc6c6321d4e369352e.