Bug #62313

InstallTool should set SYS/trustedHostsPattern on initial install

Added by Mathias Schreiber about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
2014-10-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

The install tool should be able to set a meaningful default for SYS/trustedHostsPattern on its initial install.
This way a user installing TYPO3 for the first time would not get confronted with an error message upon clicking "open Backend" after a sucessful install.

Steps to reproduce

  • Checkout current master.
  • Install the site
  • Pick no distribution
  • click "open backend" on last step
  • enjoy exception

Related issues

Related to TYPO3 Core - Feature #59355: make trustedHostsPattern use sys_domain recordsRejected2014-06-05

Actions
#1

Updated by Mathias Schreiber about 6 years ago

  • Description updated (diff)
#2

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33366

#3

Updated by Mathias Schreiber about 6 years ago

Sidenote:
Arguably the patch could check if $_SERVER['SERVER_NAME'] and $_SERVER['HTTP_HOST'] are the same and then set the value to 'SERVER'.
I somewhat consider a "real" value cleaner.

Opinions?

#4

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33366

#5

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33366

#6

Updated by Mathias Schreiber almost 6 years ago

  • Status changed from Under Review to Closed

we'll talk about this later.
Our setup is very weird

Also available in: Atom PDF