Project

General

Profile

Actions

Bug #63139

closed

Pagetree does not jump to unfolded page when creating internal link

Added by Bart Gijswijt over 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2014-11-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When creating an internal link and unfolding a page in the pagetree, the pagetree reloads but no longer jumps to the page the editor just unfolded. The editor has to scroll down to find the page again.

This is particularly annoying on large sites where you have to unfold many pages to find the target page.

Actions #1

Updated by Bryan Dijksterhuis almost 9 years ago

Bart Gijswijt wrote:

When creating an internal link and unfolding a page in the pagetree, the pagetree reloads but no longer jumps to the page the editor just unfolded. The editor has to scroll down to find the page again.

This is particularly annoying on large sites where you have to unfold many pages to find the target page.

A client of my company also found this bug. After looking around I managed to find out it is caused in the file "class.browse_links.php" in the typo3_src/typo3/ folder. The line at which the bug occurs is 115. The original code shows:

$name = ' name="' . $bMark . '"';

Note the double quotes around the $bMark variable. A couple of lines later this $name variable is inserted into the <a> tag with the htmlspecialchars function surrounding it:

return '<a href="#"' . htmlspecialchars($name) . ' onclick="' . htmlspecialchars($aOnClick) . '">' . $icon . '</a>';

This is where the bug occurs. Somehow htmlspecialchars seems to add an extra set of double quotes around the, already existing, double quotes that surround the $bMark variable. If I remove the existing double quotes around the $bMark variable like below, and save the file and try again, then the jumping-to-opened-page works exactly like expected.

TL;DR: class.browse_links.php adds redundant double quotes on line 115 which means the value of the name tag doesn't match the value set in the onclick action.

This was tested on a TYPO3 6.2.9.

If you need more information, let me know and I'll see what I can do for you :)

Sincerely yours,

Bryan Dijksterhuis
Youwe

Actions #2

Updated by Bart Gijswijt almost 9 years ago

This looks fixed in 6.2.14, right?

Actions #3

Updated by Wouter Wolters over 8 years ago

  • Status changed from New to Closed

yes this has been fixed with #66854

Actions

Also available in: Atom PDF