Project

General

Profile

Actions
Copy link

Bug #63650

closed

enableFields WHERE clause filter reference check (Contains Fix Patch)

Added by Friesen Kiwi over 9 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2014-12-08
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php

Line 7276 should be wrapped in an if:

        return $GLOBALS['TSFE']->sys_page->enableFields($table, $show_hidden, $ignore_array);



        if(is_object($GLOBALS['TSFE']->sys_page)){
            return $GLOBALS['TSFE']->sys_page->enableFields($table, $show_hidden, $ignore_array);
        }

otherwise throws Fatal Error with cal extension scheduler call because of NULL reference

Actions
Copy link
 #1

Updated by Markus Klein over 9 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (next-patchlevel)
  • % Done changed from 90 to 0

This is a bug of the extension. ContentObjectRenderer should only be used for frontend and not from within a CLI context.

Actions
Copy link
 #2

Updated by Friesen Kiwi over 9 years ago

Hm, might be, but then the API should prevent usage within a CLI context (private method etc.?). If you look at the function seperately, it is susceptible to NULL pointer fatal errors, which shouldn't be the case. If usage of the class has some precondition, it should check for it and fail graceful. :-)
Happy new year!

Actions
Copy link
 #3

Updated by Markus Klein over 9 years ago

  • Status changed from Needs Feedback to Rejected

Don't know how a private method should help, but the class is already in the "frontend" sysext. I consider that already a good hint about its usage.

Generally we have way too many public methods around, but that is due to history.

Actions
Copy link

Also available in: Atom PDF