Project

General

Profile

Actions
Copy link

Bug #65227

closed

TCE-Form validation behaviour is incomplete for range

Added by Christian Herberger over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2015-02-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When you use a TCA field type select with multiple, minItems 1 and maxItems n, the indicator for the validity of the form field is behaving incorrect:

- You have an empty field: The icon is there (correct)
- You select an element: The icon does not disappear (incorrect)
- You select a second element: The icon does disappear (correct, but too late)
- You remove both selected elements: The icon stays hidden (incorrect)
- You select an element: The icon does appear again (incorrect)

In 4.5 the behaviour was correct.

Research/Debugging showed that in 4.5 there was an onclick event on the Remove Element cross icon, which validated the field instantly and displayed the icon if the field was empty. Also, in 4.5 the event which validates the field after selecting an element was triggered after the element is taken into the selected elements, in 6.2 the validation is run before that moment (thus, the validation runs on an empty list, displays the icon, then the element is selected)

Actions
Copy link
 #1

Updated by Wouter Wolters over 9 years ago

Hi does this issue still exists in current master?
The validation code has been rewritten because of so many problems.

Actions
Copy link
 #2

Updated by Wouter Wolters over 9 years ago

  • Status changed from New to Needs Feedback
Actions
Copy link
 #3

Updated by Christian Herberger over 9 years ago

Hi,

unfortunately the master or the 7.x distributions aren't an option for the project I'm working on. When will the issue be addressed for 6.2? I'm sure an issue like this is to be fixed within the terms of an LTS?

Regards, Christian Herberger

Actions
Copy link
 #4

Updated by Wouter Wolters over 9 years ago

  • Status changed from Needs Feedback to Closed

Hi,

The validation code is 12 years old and nobody darred to fix this stuff.
Now with version 7 Frank Nägler did an amazing job by rewriting this from scratch. See https://review.typo3.org/#/c/40912/

I had a discussion with Frank about this ticket and the conclusion is, despite the LTS status, that we don't fix this in 6.2.
The code is buggy in several places and if we start fixing this we have a big chance of creating new bugs.
We do not want new bugs in 6.2. For version 7LTS we have some months left for extensive testing.

Kind regards,

Wouter Wolters
TYPO3 CMS Active Contributor

Actions
Copy link

Also available in: Atom PDF