Project

General

Profile

Actions
Copy link

Task #65377

closed

Avoid duplicated code when using getters for $GLOBALS

Added by most wanted about 9 years ago. Updated about 9 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
most wanted
Category:
-
Target version:
next-patchlevel
Start date:
2015-02-27
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

It is good practice to use getters for to get $GLOBALS array entries. This (can) lead to quite some duplicated code both in the core of TYPO3 CMS and 3rd party extensions. To avoid the need of this duplicated code it may make sense to put those getters as static methods into a designated class.

Example: \TYPO3\CMS\Core\Utility\GlobalsUtility::getLanguageService()

Actions
Copy link
 #1

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37308

Actions
Copy link
 #2

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37308

Actions
Copy link
 #3

Updated by Wouter Wolters about 9 years ago

  • Status changed from Under Review to Rejected
Actions
Copy link

Also available in: Atom PDF