Project

General

Profile

Actions

Bug #68670

closed

Do not let legacy code take precedence over HTTP headers

Added by Helmut Hummel over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-07-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

The code to not overwrite regular headers set by PSR-7 response
is obsolete and should be removed. Legacy code does not have access
to the response object, thus the PSR-7 header list would always be empty.

We also do not want to give legacy code precedence here if our code
explicitly sets some headers.
Also make sure that, if legacy code added some headers, which are also
set in the response object, that the headers are not additionally added
but override the legacy headers.

The only exception is the status code header, which we must allow to
be changed from legacy code for the time being.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #68506: Extbase must use response-object to set response-headers/statuscodeClosed2015-07-24

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42161

Actions #2

Updated by Helmut Hummel over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42351

Actions #4

Updated by Daniel Maier over 9 years ago

  • Status changed from Under Review to Closed

Was reopened erroneously.

Actions

Also available in: Atom PDF