Bug #69475

Streamline unit tests for GeneralUtility::sanitizeLocalUrl

Added by Nicole Cordes about 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Tests
Target version:
Start date:
2015-09-02
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Currently the unit tests for the function GeneralUtility::sanitizeLocalUrl are just working by accident. To add further tests we should streamline the tests and set/add expectations.

Associated revisions

Revision 386c5eb7 (diff)
Added by Nicole Cordes about 5 years ago

[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl

Currently the Unit Tests for the function just work by accident. As
HTTP_HOST an absolute path is set which is used to get some other values
to compare the given strings. To add further tests we should streamline
the tests and set/add expectations for host and script_name.

Resolves: #69475
Releases: master, 6.2
Change-Id: If139da7bd22c1ebf2c538cd3412fb0abf56dc668
Reviewed-on: http://review.typo3.org/42982
Reviewed-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Frans Saris <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

Revision 7774a086 (diff)
Added by Nicole Cordes about 5 years ago

[BUGFIX] Streamline Unit Tests for GeneralUtility::sanitizeLocalUrl

Currently the Unit Tests for the function just work by accident. As
HTTP_HOST an absolute path is set which is used to get some other values
to compare the given strings. To add further tests we should streamline
the tests and set/add expectations for host and script_name.

Resolves: #69475
Releases: master, 6.2
Change-Id: If139da7bd22c1ebf2c538cd3412fb0abf56dc668
Reviewed-on: http://review.typo3.org/42988
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>

History

#1 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42982

#2 Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42982

#3 Updated by Nicole Cordes about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review about 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42988

#5 Updated by Nicole Cordes about 5 years ago

  • Status changed from Under Review to Resolved

#6 Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF