Bug #70526

Location of formatToPageTypeMapping option

Added by Christian Futterlieb over 3 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2015-10-09
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

As in #66352 mentioned, the option formatToPageTypeMapping has to be configured in

plugin.tx_myextension.settings.view.formatToPageTypeMapping

instead of
plugin.tx_myextension.view.formatToPageTypeMapping

which is be the obvious logical location. The latter is also documented in http://forge.typo3.org/attachments/download/26372/TYPO3-v6-2-whats-new.english.pdf

This could be resolved by changing the constant when fetching the configuration:

// current
$settings = $this->configurationManager->getConfiguration(\TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::CONFIGURATION_TYPE_SETTINGS, $extensionName);

// resolution
$settings = $this->configurationManager->getConfiguration(\TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::CONFIGURATION_TYPE_FRAMEWORK, $extensionName);

IMO this is a bug, but resolving it would be a breaking change for extensions. I'll push a possible solution to gerrit to discuss it there.

Associated revisions

Revision 4e9f8109 (diff)
Added by Christian Futterlieb over 1 year ago

[BUGFIX] Move option formatToPageTypeMapping

Move the option formatToPageTypeMapping from
plugin.tx_myextension.settings.view.formatToPageTypeMapping to
plugin.tx_myextension.view.formatToPageTypeMapping

and deprecate the usage of the wrong location.

Resolves: #70526
Releases: master
Change-Id: I660aa41097e6cdba5e8fb90591a67a0b83ee90f2
Reviewed-on: https://review.typo3.org/43926
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43926

#2 Updated by Markus Sommer over 3 years ago

  • Assignee set to Christian Futterlieb

#3 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43926

#4 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43926

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43926

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43926

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43926

#8 Updated by Christian Futterlieb over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF