Bug #70648

Fix failing unit test in composer mode

Added by Nicole Cordes about 5 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
composer
Target version:
Start date:
2015-10-13
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If you're running core unit tests in composer mode you get on failing test:

There was 1 failure:

1) TYPO3\CMS\Install\Service\CoreUpdateServiceTest::isCoreUpdateEnabledReturnsTrueForEnvironmentVariableNotSet
Failed asserting that false is true.

D:\Server\typo3\composer.typo3.local\vendor\typo3\cms\typo3\sysext\install\Tests\Unit\Service\CoreUpdateServiceTest.php:43
D:\Server\typo3\composer.typo3.local\vendor\phpunit\phpunit\phpunit:47

Associated revisions

Revision ff91a5d0 (diff)
Added by Nicole Cordes almost 5 years ago

[BUGFIX] Skip unit test depending on Composer mode

The test isCoreUpdateEnabledReturnsTrueForEnvironmentVariableNotSet in
\TYPO3\CMS\Install\Service\CoreUpdateServiceTest depends on the
TYPO3_COMPOSER_MODE environment variable. This test should be skipped
if unit tests are running in Composer mode. An additional test for the
Composer mode is added to ensure the updater returns false.

Resolves: #70648
Releases: master
Change-Id: Iaedd9d0ab2c3877924fc41a6f9e2d4692c6d2f0a
Reviewed-on: https://review.typo3.org/44026
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44026

#2 Updated by Nicole Cordes almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Riccardo De Contardi almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF