Project

General

Profile

Actions

Bug #70883

closed

Fix FloatValidatorTest of EXT:form on windows

Added by Stephan Großberndt over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Target version:
Start date:
2015-10-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

The FloatValidatorTest of EXT:form uses only one locale 'en_US' when trying to set the locale. This fails on windows.

 '12.1 for en_US locale' => array(array('12.1', 'en_US')),

Allowed locales for windows: https://msdn.microsoft.com/en-us/library/39cwe7zf%28v=vs.90%29.aspx

Instead an array can be passed making the test work on windows too.

 '12.1 for en_US locale' => array(array('12.1', ['en_US', 'english'])),
Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from In Progress to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/40477

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44187

Actions #3

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44187

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44187

Actions #5

Updated by Stephan Großberndt over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF