Bug #71458

fullQuoteArray can't handle boolean values for $noQuote

Added by Nicole Cordes over 3 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2015-11-10
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The api for fullQuoteArray allows the parameter $noQuote to be boolean but converts it automatically to false in line 884 as $noQuote isn't a string nor an array. We should either change the function or the parameter description.

Associated revisions

Revision 31009f1e (diff)
Added by Morton Jonuschat over 3 years ago

[!!!][BUGFIX] Fix boolean noQuote option in DatabaseConnection::fullQuoteArray

The api for fullQuoteArray allows the parameter $noQuote to be boolean.
This patch corrects the handling of the case when true is being passed
as value for $noQuote.

Resolves: #71458
Releases: master
Change-Id: I332934a471b1e8d7310272bcc2164a375104cb07
Reviewed-on: https://review.typo3.org/46017
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Morton Jonuschat over 3 years ago

  • Category set to Database API (Doctrine DBAL)

#2 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46017

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46017

#4 Updated by Morton Jonuschat over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF