Bug #72782

Escape Windows realpath for blacklist generation in ClassLoadingInformationGenerator::createClassMap

Added by Nicole Cordes almost 5 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2016-01-17
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Windows paths contain backslashes. Those have to be escaped for the usage within regular expression. Furthermore the ClassMapGenerator converts backslashes in the given path into forward slashes. Therefore the built expression is wrong and we have to convert the path before building the blacklist regular expression.


Related issues

Duplicated by TYPO3 Core - Bug #73520: Class not found on cleanup all caches via BE on Windows Closed 2016-02-17

Associated revisions

Revision adc60cc6 (diff)
Added by Nicole Cordes over 4 years ago

[BUGFIX] Convert slashes in Windows paths for blacklist generation

The composer ClassMapGenerator expects the blacklist regular expression
to contain forward slashes. As the realpath of a given file is used it
has to be converted before using it in the expression.

Resolves: #72782
Releases: master, 7.6
Change-Id: Ia61a490be4cee4c8b7c492b4514bff2d720343ae
Reviewed-on: https://review.typo3.org/46039
Reviewed-by: Helmut Hummel <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Xavier Perseguers <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Benni Mack <>
Tested-by: Helmut Hummel <>

Revision d919443d (diff)
Added by Nicole Cordes over 4 years ago

[BUGFIX] Convert slashes in Windows paths for blacklist generation

The composer ClassMapGenerator expects the blacklist regular expression
to contain forward slashes. As the realpath of a given file is used it
has to be converted before using it in the expression.

Resolves: #72782
Releases: master, 7.6
Change-Id: Ia61a490be4cee4c8b7c492b4514bff2d720343ae
Reviewed-on: https://review.typo3.org/46766
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

History

#1 Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46039

#2 Updated by Nicole Cordes over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46766

#4 Updated by Nicole Cordes over 4 years ago

  • Status changed from Under Review to Resolved

#5 Updated by Riccardo De Contardi almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF