Bug #72948: Special characters in Flashmessages are converted to HTML entities twice - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #72948

closed

Special characters in Flashmessages are converted to HTML entities twice

Added by Marco Huber about 8 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2016-01-26

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

In TYPO3\CMS\Backend\Controller\EditDocumentController::makeEditForm() line 1095 the message which is shown if somebody else edits the current record, is sent through htmlspecialchars.
In TYPO3\CMS\Core\Messaging\FlashMessageQueue::renderFlashMessages() the message is sent through htmlspecialchars, too.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Marco Huber about 8 years ago

This happens everywhere where TYPO3\CMS\Core\Messaging\FlashMessage::render() is replaced by TYPO3\CMS\Core\Messaging\FlashMessageService and TYPO3\CMS\Core\Messaging\FlashMessageQueue.

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46245

Actions

Copy link

Updated by Marco Huber about 8 years ago

This is the regex I used:

FlashMessage::class,(\r\n?|\n)*?.*?htmlspecialchars

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46301

Actions

Copy link