Project

General

Profile

Actions

Bug #73986

closed

Regression: Change in ResourceCompressor prevents creation of compressed CSS files

Added by Michiel Roos over 8 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2016-03-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

Introduced in Change-Id: If72f3ef4b385c253e610c11ea920cc1fab48edff
Commit: 5ee15e4a41b4b6e85196358ce6af357c34ca1358

https://review.typo3.org/#/c/46821/4/typo3/sysext/core/Classes/Resource/ResourceCompressor.php@356

Instances of (PATH_site . $targetFile) were replaced by $filenameAbsolute. These do NOT yield similar strings.

For example:

"/var/www/dev-master.local.typo3.org/typo3/sysext/t3skin/Resources/Public/Css/backend.css"
is not equal to
"/var/www/dev-master.local.typo3.org/typo3temp/assets/compressed/backend-38ec86af21587926c000b6e8facff914.css"

The $filenameAbsolute most likely already exists, so the 'creation' of the compressed resource is skipped.

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47002

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47002

Actions #3

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47002

Actions #4

Updated by Michiel Roos over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF