Bug #77588

SQL Error / Check links

Added by Daniel Windloff over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2016-08-22
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

It is possible to get a sql-error in EXT:linkvalidator (info module).

Steps to reproduce:
  • Create an empty, hidden page
  • Go to the linkvalidator
  • Run check links (select all link types; check level: This page)
  • Get exception Doctrine\DBAL\Exception\SyntaxErrorException (master)

Reason:
LinkAnalyzer::getLinkStatistics doesn’t check against an empty $pidList and could generate an invalid sql-query.

Tested in master(8)/7.6/6.2.


Related issues

Related to TYPO3 Core - Task #76558: Doctrine: Migrate ext:linkvalidator/LinkAnalyzer.php Closed 2016-06-09

Associated revisions

Revision 41243d94 (diff)
Added by Daniel Windloff over 3 years ago

[BUGFIX] Fix sql error in EXT:linkvalidator

If no page is selected, skip sql queries in LinkAnalyzer
getLinkStatistics.

Resolves: #77588
Releases: master, 7.6, 6.2
Change-Id: I3b45cbad6962c5327d860b182e61255018bf0e53
Reviewed-on: https://review.typo3.org/49547
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Benni Mack <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision 65b60c50 (diff)
Added by Daniel Windloff over 3 years ago

[BUGFIX] Fix sql error in EXT:linkvalidator

If no page is selected, skip sql queries in LinkAnalyzer
getLinkStatistics.

Resolves: #77588
Releases: master, 7.6, 6.2
Change-Id: I3b45cbad6962c5327d860b182e61255018bf0e53
Reviewed-on: https://review.typo3.org/49563
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision b495775f (diff)
Added by Daniel Windloff over 3 years ago

[BUGFIX] Fix sql error in EXT:linkvalidator

If no page is selected, skip sql queries in LinkAnalyzer
getLinkStatistics.

Resolves: #77588
Releases: master, 7.6, 6.2
Change-Id: I3b45cbad6962c5327d860b182e61255018bf0e53
Reviewed-on: https://review.typo3.org/49564
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49547

#2 Updated by Daniel Windloff over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49563

#4 Updated by Daniel Windloff over 3 years ago

  • Status changed from Under Review to Resolved

#5 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49564

#6 Updated by Daniel Windloff over 3 years ago

  • Status changed from Under Review to Resolved

#7 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF