Bug #77841

BE user doesn't get file upload button in inline FAL fields if the "Add Folder" permission is not set

Added by Felix Rauch over 2 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-09-04
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

A BE user does not get the "Select & Upload files" button if they are not given the "Add Folder" permission. The "Add File" permission is not checked.

How to reproduce:
  1. Create a BE user with any mix of file operation permissions, as long as the "Folder/Directory Add" permission is not given.
  2. As the BE user, create a CE of the type "Text and Media".
  3. Switch to the "Media" tab in the CE form
  4. The button is not visible. Via the "Add media" button, files can still be uploaded.

This issue is also present in version 7LTS, a backport should be fairly straightforward.


Related issues

Blocked by TYPO3 Core - Bug #77856: BackendUserAuthentication::getDefaultUploadFolder checks the wrong permission flag Closed 2016-09-05

Associated revisions

Revision 734a5fc3 (diff)
Added by Felix Rauch over 2 years ago

[BUGFIX] IRRE file upload button not shown to BE user

If the logged in BE user does not have the "addFolder"
file operation permission, the button for uploading
files in IRRE forms is not shown. This commit fixes
this by checking for the "addFile" permission instead.

When fetching the default upload folder, TYPO3 already
checks whether the user is allowed to write to that
particular folder.

Releases: master,7.6
Resolves: #77841
Change-Id: Ic76d5fb36fd39b9fbcc554b9f03517c3cb1f301a
Reviewed-on: https://review.typo3.org/49867
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

Revision b320dbc6 (diff)
Added by Felix Rauch over 2 years ago

[BUGFIX] IRRE file upload button not shown to BE user

If the logged in BE user does not have the "addFolder"
file operation permission, the button for uploading
files in IRRE forms is not shown. This commit fixes
this by checking for the "addFile" permission instead.

When fetching the default upload folder, TYPO3 already
checks whether the user is allowed to write to that
particular folder.

Releases: master,7.6
Resolves: #77841
Change-Id: Ic76d5fb36fd39b9fbcc554b9f03517c3cb1f301a
Reviewed-on: https://review.typo3.org/49870
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

History

#1 Updated by Felix Rauch over 2 years ago

I have a bugfix prepared for this. Will push the review once the mobile internet stabilizes.

#2 Updated by Frans Saris over 2 years ago

Hi Felix,

tnx for picking this up! Waiting for you patch :)

#3 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49867

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49870

#5 Updated by Felix Rauch over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF