Project

General

Profile

Actions

Bug #78444

closed

TCA type "imageManipulation" does not use enableZoom

Added by Philip Majewski over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Start date:
2016-10-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

As described in https://docs.typo3.org/typo3cms/extensions/core/Changelog/7.2/Feature-65585-AddTCATypeImage_manipulation.html
there is a field called enableZoom. As a matter of fact the field value is never passed to the ImageManipulationWizard.

In typo3/sysext/backend/Classes/Form/Wizard/ImageManipulationWizard.php - $queryParams['bool'] is used but the correct param would be $queryParams['zoom'] as it is passed as

$wizardData = [
                'zoom' => $config['enableZoom'] ? '1' : '0',
                'ratios' => json_encode($config['ratios']),
                'file' => $file->getUid(),
            ];

In
typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php

Actions #1

Updated by Philip Majewski over 7 years ago

  • Category set to Backend API
Actions #2

Updated by Philip Majewski over 7 years ago

So when I change $queryParams['bool'] to $queryParams['zoom'] in ImageManipulationWizard I get a zoom in/out button in the image editor.

Actions #3

Updated by Philip Majewski over 7 years ago

  • Assignee set to Philip Majewski

How to reproduce the bug:

Add a TCA column from type imageManipulation and set enableZoom to true. After clearing caches the crop editor won't show any zooming buttons as expected.

'crop' => array(
     'exclude' => 1,
      'label' => 'LLL:EXT:lang/locallang_tca.xlf:sys_file_reference.crop',
       'config' => array(
           'type' => 'imageManipulation',
           'enableZoom' => true
        )
 ),
Actions #4

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50386

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50386

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50394

Actions #7

Updated by Philip Majewski over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF